Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

net_http.rb: StubSocket needs read_timeout for aws-sdk #149

Merged
merged 1 commit into from

2 participants

@godfat

Sorry that I failed to find out how to reproduce this in a simple
way without using aws-sdk, ending up with Net::WebMockNetBufferedIO
instead of StubSocket. aws-sdk is maintaining a connection pool which
is too complicated and I am tired of digging into it. Time to sleep...

Thanks!

@godfat godfat net_http.rb: StubSocket needs read_timeout for aws-sdk
Sorry that I failed to find out how to reproduce this in a simple
way without using aws-sdk, ending up with Net::WebMockNetBufferedIO
instead of StubSocket. aws-sdk is maintaining a connection pool which
is too complicated and I am tired of digging into it. Time to sleep...

Thanks!
9475d52
@bblimke
Owner

Would be good to have a test for it, but if this accessor is the only thing to make it work with aws sdk, then it's fine.
Thank you for investigating the issue and finding the solution!

@bblimke bblimke merged commit a3e4104 into bblimke:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 16, 2012
  1. @godfat

    net_http.rb: StubSocket needs read_timeout for aws-sdk

    godfat authored
    Sorry that I failed to find out how to reproduce this in a simple
    way without using aws-sdk, ending up with Net::WebMockNetBufferedIO
    instead of StubSocket. aws-sdk is maintaining a connection pool which
    is too complicated and I am tired of digging into it. Time to sleep...
    
    Thanks!
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  lib/webmock/http_lib_adapters/net_http.rb
View
2  lib/webmock/http_lib_adapters/net_http.rb
@@ -184,6 +184,8 @@ def check_right_http_connection
class StubSocket #:nodoc:
+ attr_accessor :read_timeout
+
def initialize(*args)
end
Something went wrong with that request. Please try again.