Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added support for Excon #158

Merged
merged 2 commits into from Feb 4, 2012

Conversation

Projects
None yet
3 participants
Contributor

dim commented Feb 3, 2012

Had to add a few pending specs, as Excon is (currently) simply ignoring userinfo in URLs. Not sure if that's the best approach. D

bblimke added a commit that referenced this pull request Feb 4, 2012

Merge pull request #158 from dim/master
Added support for Excon

@bblimke bblimke merged commit e6a9e81 into bblimke:master Feb 4, 2012

Owner

bblimke commented Feb 4, 2012

Thank you! That's a big one. Great to have one more library supported by WebMock.

Have you considered using Excon internal stubbing?

Contributor

dim commented Feb 4, 2012

I did, but not sure how that would work in combination with WebMock's internals (registry, etc). We are using exconn + net/http in many of our projects, hence I wanted to create a single, consistent way of stubbing our connections.

Owner

bblimke commented Feb 4, 2012

Thanks. It will go in Webmock 1.8.0 release within couple of days.

Owner

bblimke commented Feb 4, 2012

@myronmarston could you please check if this will cause any conflicts with Excon support in VCR, before I release 1.8.0?

Collaborator

myronmarston commented Feb 4, 2012

Yep, thanks for the heads up! I will try to get to it later this weekend.

Collaborator

myronmarston commented Feb 5, 2012

All my VCR tests pass, so this is good to go :).

Owner

bblimke commented Feb 5, 2012

Excellent! I'm planning to release 1.8.0 tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment