Fix compatibility with edge em-http-request #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for keeping em-http-request adapter up to date! |
bblimke
added a commit
that referenced
this pull request
Mar 15, 2012
Fix compatibility with edge em-http-request
|
Released as 1.8.3 |
creditbox123
pushed a commit
to AYCHCOM/Vcr
that referenced
this pull request
Mar 30, 2020
em-http-request 1.0.2, just released today, breaks WebMock's em-http-request adapter. There's a pull request to get it fixed in WebMock[1], but for now it's simplest to lock to 1.0.1. [1] bblimke/webmock#168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of igrigorik/em-http-request@add8ad4 we can no longer assume that @req.proxy is not nil.
To verify this, add
gem "em-http-request", :git => 'https://github.com/igrigorik/em-http-request.git'toGemfileand run the specs inspec/acceptance/em_http_request/em_http_request_spec.rb.