Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix compatibility with edge em-http-request #168

Merged
merged 1 commit into from

2 participants

@thoughtless

As of igrigorik/em-http-request@add8ad4 we can no longer assume that @req.proxy is not nil.

To verify this, add gem "em-http-request", :git => 'https://github.com/igrigorik/em-http-request.git' to Gemfile and run the specs in spec/acceptance/em_http_request/em_http_request_spec.rb.

@bblimke
Owner

Thank you for keeping em-http-request adapter up to date!

@bblimke bblimke merged commit 089ee50 into bblimke:master
@bblimke
Owner

Released as 1.8.3

@mfpiccolo mfpiccolo referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 13, 2012
  1. @thoughtless
This page is out of date. Refresh to see the latest.
View
2  lib/webmock/http_lib_adapters/em_http_request/em_http_request_1_x.rb
@@ -154,7 +154,7 @@ def build_request_signature
method = @req.method
uri = @req.uri
- auth = @req.proxy[:authorization]
+ auth = @req.proxy[:authorization] if @req.proxy
query = @req.query
if auth
Something went wrong with that request. Please try again.