Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixing travis-ci image to report master's status #191

Merged
merged 1 commit into from

4 participants

@ryansch

I was originally turned off of webmock when I saw that the build was failing on travis and the last commit was 2 months ago. This pull request scopes the travis status image to the master branch.

@jcf
Collaborator
jcf commented

Looks good to me.

@bblimke do you want Travis to test branches other than master?

@ryansch

Travis will continue to test other branches. This only changes the behavior of the graphic at the top of the README.

@bblimke
Owner

Looks good. I thought it was using master branch by default. Thanks for adding this param.

@bblimke bblimke merged commit 4dbc51d into from
@ryansch

Ironically, it looks like #196 broke the tests for master. :smile:

@bblimke
Owner

Not sure about that. All tests pass locally so looks like it's something specific to travis env.

@jonleighton

@bblimke I think there is some issue with a gem dependency. I had trouble with the tests locally but didn't in the past. I think if you do a bundle update on your local machine you will also have failures.

@bblimke
Owner

It's Addressable >= 2.3.0. Looks like the changes in 2.3.0 are not compatible with WebMock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 5, 2012
  1. @ryansch
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  README.md
View
2  README.md
@@ -1,4 +1,4 @@
-WebMock [![Build Status](https://secure.travis-ci.org/bblimke/webmock.png)](http://travis-ci.org/bblimke/webmock) [![Dependency Status](https://gemnasium.com/bblimke/webmock.png)](http://gemnasium.com/bblimke/webmock)
+WebMock [![Build Status](https://secure.travis-ci.org/bblimke/webmock.png?branch=master)](http://travis-ci.org/bblimke/webmock) [![Dependency Status](https://gemnasium.com/bblimke/webmock.png)](http://gemnasium.com/bblimke/webmock)
=======
Library for stubbing and setting expectations on HTTP requests in Ruby.
Something went wrong with that request. Please try again.