Fixing travis-ci image to report master's status #191

Merged
merged 1 commit into from Jul 23, 2012

Conversation

Projects
None yet
4 participants
Contributor

ryansch commented Jul 5, 2012

I was originally turned off of webmock when I saw that the build was failing on travis and the last commit was 2 months ago. This pull request scopes the travis status image to the master branch.

Collaborator

jcf commented Jul 6, 2012

Looks good to me.

@bblimke do you want Travis to test branches other than master?

Contributor

ryansch commented Jul 6, 2012

Travis will continue to test other branches. This only changes the behavior of the graphic at the top of the README.

Owner

bblimke commented Jul 23, 2012

Looks good. I thought it was using master branch by default. Thanks for adding this param.

@bblimke bblimke added a commit that referenced this pull request Jul 23, 2012

@bblimke bblimke Merge pull request #191 from ryansch/fix-travis-image
Fixing travis-ci image to report master's status
4dbc51d

@bblimke bblimke merged commit 4dbc51d into bblimke:master Jul 23, 2012

Contributor

ryansch commented Jul 23, 2012

Ironically, it looks like #196 broke the tests for master. 😄

Owner

bblimke commented Jul 23, 2012

Not sure about that. All tests pass locally so looks like it's something specific to travis env.

Contributor

jonleighton commented Jul 23, 2012

@bblimke I think there is some issue with a gem dependency. I had trouble with the tests locally but didn't in the past. I think if you do a bundle update on your local machine you will also have failures.

Owner

bblimke commented Jul 23, 2012

It's Addressable >= 2.3.0. Looks like the changes in 2.3.0 are not compatible with WebMock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment