Typhoeus 0.5.0 #212

Merged
merged 14 commits into from Nov 7, 2012

Conversation

Projects
None yet
3 participants
Contributor

i0rek commented Sep 21, 2012

This PR makes webmock work with the upcoming typhoeus release. One of the interesting things is, that the monkey patch is gone.

One thing that still needs to be addressed is that there is now more than one way to do a request. request.run no longer uses the hydra. Basically all tests must be run with hydra.run and request.run. The reason I'm not extremely concerned that everything breaks for request.run is that the before hook is quite simple and do exist for both of course.

Owner

bblimke commented Sep 24, 2012

Awesome, no monkey patching! Can't wait to merge it :)

Owner

i0rek commented on e58c990 Oct 2, 2012

I think what @myronmarston said about vcr applies here too: i0rek/vcr@84fb704#commitcomment-1928493.

The with_connection block shouldn't be there.

I updated VCR based on typhoeus/typhoeus@0caa30b so that VCR now sets request.block_connection = false on individual requests rather than wrapping them in with_connection at the point the request is made, and that worked...but I started getting failures from the webmock specs when using typhoeus because the client still has to use with_connection when using typhoeus with WebMock as demonstrated here. I can't get a green VCR build until this is fixed.

Owner

i0rek replied Oct 4, 2012

I'll take care of that. Thanks for your effort!

Contributor

i0rek commented Oct 6, 2012

Done! All green.

Collaborator

myronmarston commented Oct 6, 2012

@i0rek -- Thanks, I'll take a stab at integrating your work into VCR master this week.

Contributor

i0rek commented Oct 30, 2012

@bblimke Typhoeus 0.5 is released: https://rubygems.org/gems/typhoeus.

bblimke added a commit that referenced this pull request Nov 7, 2012

@bblimke bblimke merged commit 720f151 into bblimke:master Nov 7, 2012

Owner

bblimke commented Nov 7, 2012

@i0rek awesome. congrats! I just released WebMock 1.9.0 with your pull request merged in. Cheers.

Contributor

i0rek commented Nov 7, 2012

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment