Handles the case where a post request contains an array, and the array contains a regex. #218

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@forwardadvance

The matching_hashes? method falls over if the post request contains an array, and the
array contains a Regex, since ['a'] != [/*./]. Here I convert the Array into a Hash, and we carry on the recursion.

Nicholas Johnson Handles the case where the match is an array of Regex.
The matcher falls over if the post request contains an array, and the
array contains a Regex, since ['a'] != [/*./].
280cbc1
@bblimke
Owner
bblimke commented Oct 18, 2012

Thank you for this pull request.

I'm not quite sure what case are you trying to solve here. Do you expect ['a'] to match [/.*/]?
Does Webmock support matching hashes with regular expressions in other cases? (that was not planned :)

Would be good to see a spec which demonstrates the case you try to solve.
The spec would be needed to merge the pull request anyway.

@bblimke
Owner
bblimke commented Feb 17, 2013

Hi @trivially

I haven't received any feedback. Is this pull request still valid?

Bartosz

@bblimke bblimke closed this Feb 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment