WebMock::Util::JSON.parse fails for binary strings. #260

wants to merge 1 commit into

2 participants


Webmock includes its own JSON parser. Turns out it doesn't parse some valid JSON strings.

What's a good way to proceed here? Should I try to fix the JSON parser or would it be better to include a JSON dependency?


On further reflection: binary strings are not valid JSON. This is not a bug.

@levinalex levinalex closed this Mar 7, 2013

As you can see in the header of lib/webmock/util.json.rb it's a copied parser from Crack with date parsing removed. I don't mind updating it to the latest version from Crack (with date parsing removed :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment