QueryMapper parses query strings including nested params

[simonoff]

Got the fix from #337 but refactored and more tested

[bblimke]

Thanks for that. Much more readable with extracted methods and tests :)

There are no specs for values_to_query. Does it now also work for nested hashes and arrays?

[simonoff]

I'm not tested it. In my application I'm using to_param from Rails.

[simonoff]

Added more test for '#to_query' method.

[bblimke]

Why have you added simplecov?

[simonoff]

By simplecov i can view how many code lines covered. For example the dot notation and array notation variants not tested. And I doesn't know how they must looks like.

[simonoff]

Any updates?

[bblimke]

Sorry :) One thing preventing me from merging it is tests failing on Ruby 1.8. Probably due to simplecov which doesn't support ruby 1.8.

[simonoff]

Hm... You still want to support ruby 1.8 ?! It's not supported any more - https://www.ruby-lang.org/en/news/2013/06/30/we-retire-1-8-7/

[bblimke]

I don't mind supporting it in WebMock 1.x

[simonoff]

@bblimke So when it will be merged? Or need to make changes first? Tell me.

[bblimke]

@simonoff I'm happy to merge it as long as simplecov is removed. It's a shame to drop 1.8 support just because of simplecov added as dependency.

[simonoff]

Ok, then I will split simplecov into another PR.

[simonoff]

@bblimke Done. Was synced with latest master branch.