Limit excon dependency version #357

Merged
merged 3 commits into from Jan 16, 2014

Conversation

Projects
None yet
2 participants
@ixti
Contributor

ixti commented Jan 12, 2014

API of excon changed from 0.30.0, so specs start failing.

@ixti

This comment has been minimized.

Show comment Hide comment
@ixti

ixti Jan 13, 2014

Contributor

There were some changes to :response_block according to changelog and commits of excon.

I was unable (1am is not a good time to debug anyway) to find what exactly cause this issue, but here are some key points, I figured out:

  • by some reason Excon.new(...).get(...) fires Excon::Connection#request two times. First without :response_block, and then with it.
  • due to above, in failing specs, expectation of :response_block execution passed correctly, but then checking of response.body to be empty fails.
Contributor

ixti commented Jan 13, 2014

There were some changes to :response_block according to changelog and commits of excon.

I was unable (1am is not a good time to debug anyway) to find what exactly cause this issue, but here are some key points, I figured out:

  • by some reason Excon.new(...).get(...) fires Excon::Connection#request two times. First without :response_block, and then with it.
  • due to above, in failing specs, expectation of :response_block execution passed correctly, but then checking of response.body to be empty fails.
@bblimke

This comment has been minimized.

Show comment Hide comment
@bblimke

bblimke Jan 16, 2014

Owner

I had a look at this excon issue but I couldn't figure out what's changed. Looks like I have to spend more time on it. For the time being it looks good. Cheers!

Owner

bblimke commented Jan 16, 2014

I had a look at this excon issue but I couldn't figure out what's changed. Looks like I have to spend more time on it. For the time being it looks good. Cheers!

bblimke added a commit that referenced this pull request Jan 16, 2014

@bblimke bblimke merged commit 1095cde into bblimke:master Jan 16, 2014

1 check passed

default The Travis CI build passed
Details

@ixti ixti deleted the vid-io:fix/excon-dependency branch Jan 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment