Skip to content

Update matchers for RSpec 3's matcher protocol #372

Merged
merged 1 commit into from Mar 2, 2014

2 participants

@robolson
robolson commented Mar 2, 2014

Resolves this deprecation message when using webmock's matchers on a project with RSpec 3:

WebMock::WebMockMatcher implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the failure_message and failure_message_when_negated methods.

Since negative_failure_message is being added back in with alias_method this will continue to work for users of RSpec 2 (e.g. webmock's own test suite).

What I did loosely matches the fix that was applied to capybara.

@robolson robolson Update matchers for RSpec 3's matcher protocol
Resolves this deprecation message from RSpec 3:

WebMock::WebMockMatcher implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
a4eb976
@bblimke
Owner
bblimke commented Mar 2, 2014

Looks good. Cheers!

@bblimke bblimke merged commit 76191ac into bblimke:master Mar 2, 2014

1 check failed

Details default The Travis CI build could not complete due to an error
@bblimke
Owner
bblimke commented Mar 2, 2014

Released as 1.17.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.