Small patch to make mocked EventMachine::HttpRequest a bit more complete #70

Merged
1 commit merged into from Jan 12, 2011

Conversation

Projects
None yet
2 participants
Contributor

samstokes commented Jan 11, 2011

Hi, thanks for creating WebMock - it's very handy!

I ran into a small issue mocking some em-http-request code: our code was calling last_effective_url on the returned HttpClient, but the WebMockHttpRequest::WebMockHttpClient mocked version of that method always returns nil. This patch makes it instead just make it return the URI that was passed in, which is a reasonable behaviour for mocking a simple request (one without redirects etc).

Would be great if you could include this in the next release of the gem, so we don't have to vendor our patched version :)

Cheers,

Sam Stokes
Rapportive

Hi Sam,

I'm glad WebMock is useful to you.
Thanks for the patch. It's now released in version 1.6.2

Bartosz

Contributor

samstokes commented Jan 13, 2011

Thanks Bartosz!

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment