Skip to content

Fix gemspec #94

Closed
wants to merge 6 commits into from

2 participants

@sferik
sferik commented May 18, 2011

This pull request does the following:

  • Replaced Jeweler with Bundler::GemHelper.install_tasks because Jeweler was causing problems and is unnecessary
  • Fix specs to work with the latest version of curb, which returns "Moved Temporarily" instead of "Found" for HTTP 302.
  • Opt-in for testing with rubygems-test
  • Cleaned up end-of-line whitespace. This makes contributing much nicer for vim users.
@sferik
sferik commented May 18, 2011

I put all these changes in separate commits, so it should be easy for you to pull only the changes you want.

@jcf
Collaborator
jcf commented May 18, 2011

Hi Erik,

I've just pushed a load of commits. Most of what's in this pull request is in there with the following exceptions.

I've left out opt-in for testing (sferik@99848c8) because there's no diff rendered and as a result it's not immediately obvious what the difference is.

I've not done the whitespace clean up yet. I plan on doing that at the same time as running set et|retab with argdo to make sure there's no trailing whitespace and no mixed tabs. This will obviously rewrite a whole lot of the gem and I want it to be clear that's all it is. Just whitespace changes.

I've not merged the latest version of curb fix (sferik@4ce59f5) because when I run specs against curb v0.7.15 with the changeset in place I get spec failures, which I don't without the sferik@4ce59f5 commit.

Everything else is in there. Thanks for your help with all of this. I'm happy to revisit any of these omissions but will close this pull request for now.

@jcf jcf closed this May 18, 2011
@sferik
sferik commented May 18, 2011

sferik@99848c8 touched a blank file called .gemtest. That's why it's not showing in the diff. For more info, see: http://test.rubygems.org/

@jcf
Collaborator
jcf commented May 18, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.