New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for locales/ synchronization #257

Merged
merged 1 commit into from Aug 30, 2014

Conversation

Projects
None yet
2 participants
@pquentin
Contributor

pquentin commented Aug 30, 2014

You requested a commit for my Python helper script in pull request #255. I decided that since everything was already in JS, it would be nice to convert the script to JS to include it in tests. I tried to do so. I don't have much experience with JS, so I tried to see what the existing conventions were. If anything's wrong, please tell me.

bbondy added a commit that referenced this pull request Aug 30, 2014

Merge pull request #257 from pquentin/master
Test for locales/ synchronization

@bbondy bbondy merged commit 487c9b4 into bbondy:master Aug 30, 2014

@bbondy

This comment has been minimized.

Show comment
Hide comment
@bbondy

bbondy Aug 30, 2014

Owner

Great!

Owner

bbondy commented Aug 30, 2014

Great!

@bbondy

This comment has been minimized.

Show comment
Hide comment
@bbondy

bbondy Aug 30, 2014

Owner

Please feel free to add yourself to the about as well, I'll gladly accept a diff with that.

Owner

bbondy commented Aug 30, 2014

Please feel free to add yourself to the about as well, I'll gladly accept a diff with that.

@pquentin

This comment has been minimized.

Show comment
Hide comment
@pquentin

pquentin Sep 1, 2014

Contributor

Thank you! I'll see when I've done a bit more (if I do). Plus there's https://github.com/bbondy/codefirefox/graphs/contributors.

Contributor

pquentin commented Sep 1, 2014

Thank you! I'll see when I've done a bit more (if I do). Plus there's https://github.com/bbondy/codefirefox/graphs/contributors.

bbondy added a commit that referenced this pull request Jun 5, 2015

Merge pull request #257 from pquentin/master
Test for locales/ synchronization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment