New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder initial operations to fix first run #260

Merged
merged 1 commit into from Sep 28, 2014

Conversation

Projects
None yet
2 participants
@pquentin
Contributor

pquentin commented Sep 28, 2014

The order in initData is a bit off, so I changed it:

  1. tagsController loads tags from redis to JS
  2. lessonController loads tags from videos.json into redis (but that's too late).

(I do not explain why this was not an issue on an ArchLinux machine but was an issue on an Ubuntu machine.)

Also, the docs say "init data by visiting localhost:22935/initData" but init data is already called when launching node --harmony app. If calling initData when the server is already running is not useful, I can remove the documentation about it and remove the route.

@bbondy

This comment has been minimized.

Show comment
Hide comment
@bbondy

bbondy Sep 28, 2014

Owner

Great thank you.
Ya I like the section about re-init data in case you have data only changes. But it isn't needed in general setup I think.

Owner

bbondy commented Sep 28, 2014

Great thank you.
Ya I like the section about re-init data in case you have data only changes. But it isn't needed in general setup I think.

@bbondy bbondy closed this Sep 28, 2014

@bbondy bbondy reopened this Sep 28, 2014

bbondy added a commit that referenced this pull request Sep 28, 2014

Merge pull request #260 from pquentin/reorder-init
Reorder initial operations to fix first run

@bbondy bbondy merged commit 3bd13c4 into bbondy:master Sep 28, 2014

@pquentin pquentin deleted the pquentin:reorder-init branch Sep 28, 2014

bbondy added a commit that referenced this pull request Jun 5, 2015

Merge pull request #260 from pquentin/reorder-init
Reorder initial operations to fix first run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment