Fixes for edge #34

Merged
merged 4 commits into from Nov 28, 2011

Conversation

Projects
None yet
2 participants
@jtgeibel
Contributor

jtgeibel commented Nov 27, 2011

Bruno,

Here are 4 commits that fix various things I've run into recently. In particular dates shown on the forums were displayed as a time only (no date info) and the new RJS for submitting forum replies was giving me errors.

Some of the other changes improve compatibility with more recent versions of rails 2.3.

-Justin

@@ -8,7 +8,7 @@ class Message < ActiveRecord::Base
has_many :children, :class_name => "Message", :foreign_key => "parent_id"
has_many :message_threads
- named_scope :parents, :conditions => "parent_id IS NULL"
+ # named_scope :conversation_roots, :conditions => "parent_id IS NULL"

This comment has been minimized.

@jtgeibel

jtgeibel Nov 27, 2011

Contributor

Renamed as .parents conflicts with an existing active record method. Also commented out as this is not used anywhere yet.

@jtgeibel

jtgeibel Nov 27, 2011

Contributor

Renamed as .parents conflicts with an existing active record method. Also commented out as this is not used anywhere yet.

@@ -2,7 +2,7 @@ en:
date:
formats:
published_date: "%m/%d/%Y"
- date_ago: "%b %Y"
+ date_ago: "%b %d, %Y"

This comment has been minimized.

@jtgeibel

jtgeibel Nov 27, 2011

Contributor

In the commit that changes the display of time_ago, I only modified the english locale. Should I have updated the other locales as well?

@jtgeibel

jtgeibel Nov 27, 2011

Contributor

In the commit that changes the display of time_ago, I only modified the english locale. Should I have updated the other locales as well?

bborn added a commit that referenced this pull request Nov 28, 2011

Merge pull request #34 from jtgeibel/for-ce1-upstream
Fixes for edge date formatting and Rails 2.3.14 compatibility

@bborn bborn merged commit ce8c381 into bborn:edge Nov 28, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment