Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid name clashing #2
bboure left a comment
Thank you @mstn and sorry for late review. I must have missed it.
As you can tell, I haven't been working on this for a long time.
In what case would there be a clash in the naming?
if so, wouldn't this line re-use it?
Do you see a reason why this would be a bad idea?
and Thank you for your contrib!
The problem is when a new es domain is created. It is new for the "local" state, but it might exist on the AWS account (different project, different env...).
If it is already present in the local state, then the existing name is used.
As far as I can see, the usual approach is to add a random string to the name.
@bboure perhaps we should hold on. I think they changed how resource names are created. Previously, in many cases, a random string was added to the given name (dynamodb, lambdas, buckets...). Now, the given name is not changed. Let me understand what is the official way.