polyfill does not work in google earth internal browser #20

Closed
bboyle opened this Issue Jan 8, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@bboyle
Owner

bboyle commented Jan 8, 2015

Google Earth has an internal browser that has unknown capabilities.

It has been reported that required radio buttons prevent form submission. Unsure why.

Required field tests report some issues. (To check the tests in google earth, add them as a link and then click the link to open the internal browser.)

@bboyle bboyle added the bug label Jan 8, 2015

@bboyle bboyle self-assigned this Jan 19, 2015

@bboyle

This comment has been minimized.

Show comment
Hide comment
@bboyle

bboyle Jan 24, 2015

Owner

Suggestion:

  • on submit: Sanity check radio buttons failing required validation. Remove @required to allow submission
  • check if google earth fires the submit event when it considers a radio button invalid (if submit event is not fired, this suggestion won't work)
Owner

bboyle commented Jan 24, 2015

Suggestion:

  • on submit: Sanity check radio buttons failing required validation. Remove @required to allow submission
  • check if google earth fires the submit event when it considers a radio button invalid (if submit event is not fired, this suggestion won't work)
@bboyle

This comment has been minimized.

Show comment
Hide comment
@bboyle

bboyle Feb 6, 2015

Owner

Failing when radio button is missing @required (but required is specified on another radio button in the group).

Owner

bboyle commented Feb 6, 2015

Failing when radio button is missing @required (but required is specified on another radio button in the group).

@bboyle bboyle reopened this Feb 6, 2015

@bboyle

This comment has been minimized.

Show comment
Hide comment
@bboyle

bboyle Feb 9, 2015

Owner

Script was not failing. The presence of other errors in the form leaves the radio button marked as required, thus causing the google earth bug. This was being picked up and displayed in the UI. Needs a different solution.

Owner

bboyle commented Feb 9, 2015

Script was not failing. The presence of other errors in the form leaves the radio button marked as required, thus causing the google earth bug. This was being picked up and displayed in the UI. Needs a different solution.

@bboyle bboyle closed this in 994ad6f Feb 9, 2015

bboyle added a commit that referenced this issue Feb 9, 2015

Merge pull request #22 from bboyle/google-earth
fix #20: handling of required radio button bug
@bboyle

This comment has been minimized.

Show comment
Hide comment
@bboyle

bboyle Mar 31, 2015

Owner

bug with polyfill: #23

Owner

bboyle commented Mar 31, 2015

bug with polyfill: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment