Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polyfill does not work in google earth internal browser #20

Closed
bboyle opened this issue Jan 8, 2015 · 4 comments
Closed

polyfill does not work in google earth internal browser #20

bboyle opened this issue Jan 8, 2015 · 4 comments
Assignees
Labels
bug

Comments

@bboyle
Copy link
Owner

@bboyle bboyle commented Jan 8, 2015

Google Earth has an internal browser that has unknown capabilities.

It has been reported that required radio buttons prevent form submission. Unsure why.

Required field tests report some issues. (To check the tests in google earth, add them as a link and then click the link to open the internal browser.)

@bboyle bboyle added the bug label Jan 8, 2015
@bboyle bboyle self-assigned this Jan 19, 2015
@bboyle
Copy link
Owner Author

@bboyle bboyle commented Jan 24, 2015

Suggestion:

  • on submit: Sanity check radio buttons failing required validation. Remove @required to allow submission
  • check if google earth fires the submit event when it considers a radio button invalid (if submit event is not fired, this suggestion won't work)
@bboyle
Copy link
Owner Author

@bboyle bboyle commented Feb 6, 2015

Failing when radio button is missing @required (but required is specified on another radio button in the group).

@bboyle bboyle reopened this Feb 6, 2015
@bboyle
Copy link
Owner Author

@bboyle bboyle commented Feb 9, 2015

Script was not failing. The presence of other errors in the form leaves the radio button marked as required, thus causing the google earth bug. This was being picked up and displayed in the UI. Needs a different solution.

@bboyle bboyle closed this in 994ad6f Feb 9, 2015
bboyle added a commit that referenced this issue Feb 9, 2015
fix #20: handling of required radio button bug
@bboyle
Copy link
Owner Author

@bboyle bboyle commented Mar 31, 2015

bug with polyfill: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.