New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Finding peak properties with FOF #352

Merged
merged 7 commits into from Jun 15, 2017

Conversation

Projects
None yet
2 participants
@rainwoodman
Member

rainwoodman commented Jun 14, 2017

This PR adds PeakPosition and PeakVelocity to FOF.

The column to define the peak is passed in as peakcolumn.

I added an algorithm KDDensity for a coarse estimation of density. This can be combined with FOF to find peak positions and velocities in the catalogue. The example is in test_fof.py

rainwoodman added some commits Jun 14, 2017

call constructor after attr is initialized.
This allows us to check for BoxSize and normalize it in the base init.
Add a fast density estimator.
The density estimator uses scipy's cKDTree. Due to a bug prior to
0.19.1 we cannot support anisotropic boxsizes yet.

@rainwoodman rainwoodman force-pushed the rainwoodman:fofpeak branch from 29a7ecf to 3488752 Jun 14, 2017

@rainwoodman rainwoodman requested a review from nickhand Jun 14, 2017

@rainwoodman

This comment has been minimized.

Member

rainwoodman commented Jun 15, 2017

Travis is all green. @nickhand how do you think of the API changes? OK to merge?

@nickhand

this looks great! go ahead and merge

@rainwoodman rainwoodman merged commit 099b666 into bccp:master Jun 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 86.513%
Details

@rainwoodman rainwoodman deleted the rainwoodman:fofpeak branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment