New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFTCorr #436

Merged
merged 3 commits into from Nov 2, 2017

Conversation

Projects
None yet
2 participants
@rainwoodman
Member

rainwoodman commented Oct 31, 2017

This PR adds FFT based Correlation Function; closes #434

Main issue is that the interface between PairCount and FFTPower is different. Not sure which to follow

  • FFTPower uses .power, ['power']
  • PairCount uses .result, ['xi'].

I also added flags to LinearMesh and LogNormalCatalog to generate unitary / inverted phase realizations.

@rainwoodman rainwoodman requested a review from nickhand Oct 31, 2017

@nickhand

Looks good to me. I think we can keep "corr" and "poles" here to match "power"/"poles". I'm going to overhaul the pair count algorithms soon (#405) and we can deal with the discrepancy then

@rainwoodman

This comment has been minimized.

Member

rainwoodman commented Nov 2, 2017

OK!

@rainwoodman rainwoodman merged commit 31c6861 into bccp:master Nov 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 95.302%
Details

@rainwoodman rainwoodman deleted the rainwoodman:fftcorr branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment