New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to PCS resampling windows. #447

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
2 participants
@rainwoodman
Member

rainwoodman commented Dec 7, 2017

This requires version 0.1.37 of pmesh.

Add support to PCS resampling windows.
This requires version 0.1.37 of pmesh.

@rainwoodman rainwoodman requested a review from nickhand Dec 7, 2017

@nickhand

This looks good to me. I think we should switch "compensate" to use the functions without the first-order aliasing correction. It seems more straightforward to me

@rainwoodman

This comment has been minimized.

Member

rainwoodman commented Dec 8, 2017

@nickhand

This comment has been minimized.

Member

nickhand commented Dec 8, 2017

Change the behavior so when you set compensated=True, it uses CompensateCIC (TSC,PCS), etc
to do the window de-convolution (vs the current behavior which uses CompensateCICAliasing)

@nickhand

This comment has been minimized.

Member

nickhand commented Dec 8, 2017

I've pinned our conda build version to <3.1 so we can build the new pmesh and opened an issue about the error we are seeing

@rainwoodman

This comment has been minimized.

Member

rainwoodman commented Dec 11, 2017

Why do we want to change the behavior? The current compensation makes sure that the shotnoise spectrum is flat. If you change it it's no longer flat I suppose.

@rainwoodman rainwoodman merged commit 7b42220 into bccp:master Dec 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 95.364%
Details

@rainwoodman rainwoodman deleted the rainwoodman:pcs branch Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment