New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigfile shall look for header starting from root. #480

Merged
merged 3 commits into from Apr 30, 2018

Conversation

Projects
None yet
1 participant
@rainwoodman
Member

rainwoodman commented Apr 30, 2018

As specified in the documentation. The rational is that
this way one can always easily specify a special header block in not
in the dataset. If it were relative to the dataset then there is
no way to load the header if it is outside.

This fix solves a few occasions where scripts mysteriously stopped
working when loading catalog.

bigfile shall look for header starting from root.
As specified in the documentation. The rational is that
this way one can always easily specify a special header block in not
in the dataset. If it were relative to the dataset then there is
no way to load the header if it is outside.

This fix solves a few occasions where scripts mysteriously stopped
working when loading catalog.
@rainwoodman

This comment has been minimized.

Member

rainwoodman commented Apr 30, 2018

I suspect the HDF5 catalog source or the fits source doesn't follow this convention yet.

@rainwoodman

This comment has been minimized.

Member

rainwoodman commented Apr 30, 2018

@modichirag @emassara This is why some of your scripts stopped working. the line that forced header discovery to relative to 'dataset' part broke many scripts that reads FastPM catalogs, where 'Header/' and '1/' are at the same level.

rainwoodman added some commits Apr 30, 2018

@rainwoodman rainwoodman merged commit 16237f3 into bccp:master Apr 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 95.375%
Details

@rainwoodman rainwoodman deleted the rainwoodman:bigfile-header-from-root branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment