New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PairCount crashes if two data sets are of different dtypes. #482

Merged
merged 3 commits into from May 3, 2018

Conversation

Projects
None yet
1 participant
@rainwoodman
Member

rainwoodman commented May 3, 2018

This PR fixes the crash if data and random are of different dtypes in SurveyDataPairCount and SimulationBoxPairCount. Both use corrfunc which doesn't handle this case.

Therefore we cast the input to the type of pos2 instead of throwing a mysterious CorrFunc error.

rainwoodman added some commits May 3, 2018

Do not crash if the input data of PairCount are of different dtypes.
We will always cast to the dtype of the second data set.

The test cases need to be released a bit to allow some round off errors.
(kdcount treats this slightly differently)

@rainwoodman rainwoodman force-pushed the rainwoodman:paircount-dtype-mis branch from 668c138 to cd26863 May 3, 2018

@rainwoodman rainwoodman merged commit ffb6dd3 into bccp:master May 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 95.377%
Details

@rainwoodman rainwoodman deleted the rainwoodman:paircount-dtype-mis branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment