New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use saner column / attr names in paircount result. #490

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
2 participants
@rainwoodman
Member

rainwoodman commented May 15, 2018

wnpairs : weighted npairs (per bin implied)

total : total (no longer per bin)

paircount.pairs.attrs['total_wnpairs'] shall be prefered than
paircount.attrs['total_wnpairs'] -- leave this change to the next
PR.

@rainwoodman rainwoodman force-pushed the rainwoodman:paircount-names branch from 167f844 to f9388e3 May 19, 2018

use saner column / attr names in paircount result.
wnpairs : weighted npairs (per bin implied)

total : total (no longer per bin)

paircount.pairs.attrs['total_wnpairs'] shall be prefered than
paircount.attrs['total_wnpairs'] -- leave this change to the next
PR.

@rainwoodman rainwoodman force-pushed the rainwoodman:paircount-names branch from edecd74 to 8d7dadb May 19, 2018

@rainwoodman rainwoodman requested a review from nickhand May 19, 2018

@nickhand

This comment has been minimized.

Member

nickhand commented May 25, 2018

@rainwoodman I hope to take a look at this this weekend.

@nickhand

I like this change and everything looks good to me

@rainwoodman rainwoodman merged commit 5d449a7 into bccp:master May 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 95.189%
Details
@rainwoodman

This comment has been minimized.

Member

rainwoodman commented May 29, 2018

Thanks!

@rainwoodman rainwoodman deleted the rainwoodman:paircount-names branch May 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment