New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compute method and remove Catalog interface from CatalogMesh. #498

Merged
merged 4 commits into from Jun 1, 2018

Conversation

Projects
None yet
1 participant
@rainwoodman
Member

rainwoodman commented May 31, 2018

This is required to add a compute method to MeshSource. Because
if CatalogMesh is a CatalogSource then CatalogSource.compute comes
into the way.

I think this PR also sheds some light on how to deal with the temporary
variables created during FKP/convpower. They probably shall be saved
as attributes of the CatalogMesh objects directly, rather than stored
as columns of the underlying sources.

@rainwoodman rainwoodman changed the title from Remove Catalog interface from CatalogMesh. to Add compute method and remove Catalog interface from CatalogMesh. May 31, 2018

@rainwoodman

This comment has been minimized.

Member

rainwoodman commented May 31, 2018

This PR is one step closer to a clean merge of #450 .

I stopped adding .compute() method to the algorithms, because it would require lifting the load / save method to a new class, which seems to be an overkill.

@rainwoodman

This comment has been minimized.

Member

rainwoodman commented May 31, 2018

Replaces #484

rainwoodman added some commits May 31, 2018

Remove Catalog interface from CatalogMesh.
This is required to add a compute method to MeshSource. Because
if CatalogMesh is a CatalogSource then CatalogSource.compute comes
into the way.

I think this PR also sheds some light on how to deal with the temporary
variables created during FKP/convpower. They probably shall be saved
as attributes of the CatalogMesh objects directly, rather than stored
as columns of the underlying sources.

@rainwoodman rainwoodman force-pushed the rainwoodman:compute-method branch from 78a3492 to 5dc1033 Jun 1, 2018

rainwoodman added some commits Jun 1, 2018

@rainwoodman rainwoodman merged commit d758c47 into bccp:master Jun 1, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
coverage/coveralls Coverage decreased (-0.2%) to 95.086%
Details

@rainwoodman rainwoodman deleted the rainwoodman:compute-method branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment