New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFTPower and FFTCorr supports Unique |k| or |r| bins. #500

Merged
merged 3 commits into from Jun 4, 2018

Conversation

Projects
None yet
1 participant
@rainwoodman
Member

rainwoodman commented Jun 1, 2018

This PR also changes the file format of FFTPower.save and FFTCorr.save,
as they now also need to save the centers, which are no longer strictly
derived from the edges.

BinnedStatistic is extended to accept bin label coordinates as an external
argument. Of course rebinning would totally mess up the centers.

ProjectedFFTPower is left unchanged because it may eventually be rewritten with
the new 'transpose interface' of pmesh and improved support on 2d / 1d.

The edge property on FFTPower and FFTCorr, attached by the run method are now
removed. Use the edge property of the power object and corr object instead.

The 'run' function of FFTPower and FFTCorr are changed to be more 'function' like.

rainwoodman added some commits Jun 1, 2018

Support dk=0 and dr=0 in FFTPower and FFTCorr
This PR also changes the file format of FFTPower.save and FFTCorr.save,
as they now also need to save the centers, which are no longer strictly
derived from the edges.

BinnedStatistic is extended to accept bin label coordinates as an external
argument. Of course rebinning would totally mess up the centers.

ProjectedFFTPower is left unchanged because it may eventually be rewritten with
the new 'transpose interface' of pmesh and improved support on 2d / 1d.

The edge property on FFTPower and FFTCorr, attached by the run method are now
removed. Use the edge property of the power object and corr object instead.
Add return values to FFTPower.run and FFTCorr.run
This is to make them more or less like .compute().

@rainwoodman rainwoodman force-pushed the rainwoodman:unique-bins branch from c026ca7 to e9fc4ed Jun 1, 2018

@rainwoodman rainwoodman merged commit 1d851a6 into bccp:master Jun 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 95.111%
Details

@rainwoodman rainwoodman deleted the rainwoodman:unique-bins branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment