New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rework the class hierarchy of Catalogmesh. #519

Merged
merged 25 commits into from Sep 26, 2018

Conversation

Projects
None yet
1 participant
@rainwoodman
Member

rainwoodman commented Aug 27, 2018

  • MultispeciesCatalogMesh is no longer a subclass of CatalogMesh; it is simply a collection of Catalogmeshes that share the resampling window, Nmesh, and BoxSize. The catalogmesh.py and decomposed.py are no longer in the base directory.

  • convpower and associated sources are moved to the same directory, to facilitate further changes of the FKP algorithm for #510 , #456

  • CatalogMesh can now be directly used to create a Mesh using arbitrary data columns, not necessarily a columnaccessor of the catalog.

  • next work item: remove the temporarily created columns defined in FKPCatalog for the weights.

@rainwoodman rainwoodman requested a review from ybh0822 Sep 6, 2018

@rainwoodman rainwoodman force-pushed the rainwoodman:catalogmesh-rewrite branch from b3a99ac to 8d86126 Sep 12, 2018

rainwoodman added some commits Sep 20, 2018

Add unique bins support to ConvolvedFFTPower
This requires a newer version of pmesh. (0.1.51).
Add test case for #523.
doesn't stall or crash though.

@rainwoodman rainwoodman merged commit c391b1f into bccp:master Sep 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 94.954%
Details

@rainwoodman rainwoodman deleted the rainwoodman:catalogmesh-rewrite branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment