New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOD and MPI #538

Merged
merged 4 commits into from Dec 10, 2018

Conversation

Projects
None yet
1 participant
@rainwoodman
Copy link
Member

rainwoodman commented Dec 10, 2018

This PR improves the HOD module speed on MPI.

It stops the HOD module from gathering the data to root rank before farming it to halotools.
This works fine for Zheng07, but may be wrong for other modules. The plan is if we find
anomaly, then switch to a method that uses LBox, and SubVolumesCatalog.

rainwoodman added some commits Dec 10, 2018

Stop gatherring the catalog to a single rank for HOD.
At least for Zheng model this appears to be correct.

For abundance based halotools models this can be a problem.
Will fix others when anomaly rises.

@rainwoodman rainwoodman merged commit 757c207 into bccp:master Dec 10, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 94.852%
Details

@rainwoodman rainwoodman deleted the rainwoodman:halotools-mpi branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment