Skip to content

Improve checks in order to prevent a crash reading (ASAR) L0 products #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forman merged 1 commit into from
Nov 9, 2011
Merged

Improve checks in order to prevent a crash reading (ASAR) L0 products #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/epr_param.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,29 @@ int epr_set_dyn_dddb_params(EPR_SProductId* product_id)
}

field = epr_get_field(product_id->sph_record, "LINE_LENGTH");
if (field == NULL) {
epr_set_err(e_err_invalid_value,
"epr_set_param: wrong SPH: unable to read LINE_LENGTH");
epr_free_string(tmp);
return 0;
}

line_length = ((uint*) field->elems)[0];
if (line_length == 0) {
epr_set_err(e_err_invalid_value,
"epr_set_param: wrong SPH: LINE_LENGTH must be > 0");
epr_free_string(tmp);
return 0;
}

field = epr_get_field(product_id->sph_record, "LINES_PER_TIE_PT");
if (field == NULL) {
epr_set_err(e_err_invalid_value,
"epr_set_param: wrong SPH: unable to read LINES_PER_TIE_PT");
epr_free_string(tmp);
return 0;
}

num_tie_points_across = ((uint*) field->elems)[0];
if (num_tie_points_across == 0) {
epr_set_err(e_err_invalid_value,
Expand All @@ -180,6 +195,13 @@ int epr_set_dyn_dddb_params(EPR_SProductId* product_id)
else if (strcmp(EPR_ENVISAT_PRODUCT_ASAR, epr_sub_string((char*)product_field->elems, 0, 3)) == 0) {

field = epr_get_field(product_id->sph_record, "LINE_LENGTH");
if (field == NULL) {
epr_set_err(e_err_invalid_value,
"epr_set_param: wrong SPH: unable to read LINE_LENGTH");
epr_free_string(tmp);
return 0;
}

line_length = ((uint*) field->elems)[0];
if (line_length == 0) {
epr_set_err(e_err_invalid_value,
Expand Down