Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bouncycastle adds 20 bytes SHA1 hash after plain secret key instead of two bytes checksum #348

Closed
vanitasvitae opened this issue May 16, 2018 · 1 comment

Comments

@vanitasvitae
Copy link
Contributor

@vanitasvitae vanitasvitae commented May 16, 2018

As pointed out here and discussed on the mailing list (link pending), bouncycastle seems to falsely export secret keys when exporting them without a password. In that case, BC 1.59 seems to append a SHA1 hash after the secret key, instead of just a 2 bytes checksum.

I suspect, that only key export without a password is affected.

@ghost
Copy link
Collaborator

@ghost ghost commented May 16, 2018

Thanks for the report. Fixed by #349.

@bcgit bcgit closed this May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant