Exporting public keys from PGPSecretKeyRing does denote sub keys as normal keys

[vanitasvitae]

Hi!
My issue is the following: If I create a PGPSecretKeyRing containing a master key and a sub key, and then try to extract a PGPPublicKeyRing from it, the resulting key ring does only contain one key, as the sub keys are ignored. The cause for this is, that the sub keys are not carrying a PUBLIC_SUBKEY packet tag, but instead a PUBLIC_KEY tag. When creating the PGPPublicKeyRing, the sub keys are therefore ignored due to this line.

Inspecting the encoded PGPPublicKeyRing with gpg --list-packets also suggests, that only two normal public keys are exported.

I created this minimal example for you to recreate the issue.

[bcgit]

Thanks for the report. Yes, it's a bit dodgy... oh dear... try the latest beta, I think that should now be making sure the keys are converted into subkeys immediately.

https://www.bouncycastle.org/betas

Let us know how you go.

[vanitasvitae]

It seems to work now :)
Can you point me to which commit exactly fixed this issue, so I can try to create a workaround for my project until BC 1.61 is released?

Edit: Ah I see some related changes in 486c6d3

[bcgit]

Yes, it's the change to PGPKeyRingGenerator

[vanitasvitae]

For the record, I created this workaround for fixing this issue in retrospect on existing keys.
A quick test suggests, that it is working as intended, but I give no guarantees :D