Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type of PGPSecretKey.getUserIds() to Iterator<String> #362

Closed
wants to merge 1 commit into from
Closed

Change return type of PGPSecretKey.getUserIds() to Iterator<String> #362

wants to merge 1 commit into from

Conversation

@vanitasvitae
Copy link
Contributor

@vanitasvitae vanitasvitae commented Jun 7, 2018

PGPPublicKey.getUserIds() returns an Iterator<String>. PGPSecretKey.getUserIds() internally calls .getUserIds() of its public key, it however has the return type Iterator, which overlays (I'm not sure what the correct term is :D) the Iterators real generic type.

My PR changes the return type of PGPSecretKey.getUserIds() to Iterator<String> to match that of the public key.

@ghost
Copy link
Collaborator

@ghost ghost commented Jun 8, 2018

Thanks for the patch! Merged.

@bcgit bcgit closed this Jun 8, 2018
@vanitasvitae vanitasvitae deleted the vanitasvitae:getUserIdsReturnType branch Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants