Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XMSS OIDs to final RFC 8391 #513

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@securitykernel
Copy link

commented May 6, 2019

Implements #482.

OIDs for use with X.509 are not defined yet unfortunately, I could only find a draft RFC, so this PR does not touch them.

@bcgit

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Thanks, merged with some modification. Looking through the RFC I also noticed an issue with the way public keys were being encoded (the OID is meant to be used as a prefix). I've also fixed that. Any feedback would be welcome.

tonywasher pushed a commit to tonywasher/bc-java that referenced this pull request May 7, 2019

@securitykernel

This comment has been minimized.

Copy link
Author

commented May 12, 2019

LGTM

@bcgit

This comment has been minimized.

Copy link
Owner

commented May 12, 2019

Thanks. I'll mark this as done.

@bcgit bcgit closed this May 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.