Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/make shared default admin demo user for graphkb ipr 57 #59

Conversation

mathieulemieux
Copy link
Member

This PR updates docs and kc realm for new shared default admin user.

This PR should be merge after corresponding changes in graphkb_api: bcgsc/pori_graphkb_api#40.
Close #57 .

Please see comment on users in databases: #57 (comment).

@mathieulemieux mathieulemieux self-assigned this Jun 13, 2022
@mathieulemieux
Copy link
Member Author

While reviewing pori demo docs, I saw these two links:

  • A live demo of the platform is found under `pori-demo.bcgsc.ca`. This demo was deployed via docker-compose.
  • The simplest way to try out GraphKB is via the demo we provide [here](https://pori-demo.bcgsc.ca/).

    from which we are being redirected to the docs on GH and find it a bit confusing. What about removing them or changing them for the /ipr and /graphkb routes?

docs/demo.md Outdated Show resolved Hide resolved
docs/graphkb/index.md Outdated Show resolved Hide resolved
@creisle
Copy link
Member

creisle commented Jun 21, 2022

While reviewing pori demo docs, I saw these two links:

  • A live demo of the platform is found under `pori-demo.bcgsc.ca`. This demo was deployed via docker-compose.

  • The simplest way to try out GraphKB is via the demo we provide [here](https://pori-demo.bcgsc.ca/).

    from which we are being redirected to the docs on GH and find it a bit confusing. What about removing them or changing them for the /ipr and /graphkb routes?

sure, you can change them for listing both the individual /ipr and /graphkb routes

demo/kc_realm_export.json Show resolved Hide resolved
docs/demo.md Outdated Show resolved Hide resolved
docs/demo.md Outdated Show resolved Hide resolved
docs/graphkb/index.md Outdated Show resolved Hide resolved
docs/install.md Show resolved Hide resolved
docs/demo.md Outdated Show resolved Hide resolved
docs/demo.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
docs/demo.md Outdated Show resolved Hide resolved
@creisle
Copy link
Member

creisle commented Jul 20, 2022

Sorry for the review delay here, this completely fell off my radar!

@mathieulemieux mathieulemieux dismissed creisle’s stale review October 3, 2022 16:36

Changes has been made but somehow the 'Changes requested' flag is still on

@elewis2
Copy link
Collaborator

elewis2 commented Oct 3, 2022

pinging @creisle - good to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants