Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Incorrect using of Cache-controls in /system/helpers/download_helper.php #1146

Closed
CompuRoot opened this Issue · 2 comments

3 participants

@CompuRoot

If both "post-check" and "pre-check" are specified and set to 0, both are entirely ignored.

Refference: http://blogs.msdn.com/b/ieinternals/archive/2009/07/20/using-post_2d00_check-and-pre_2d00_check-cache-directives.aspx

@philsturgeon

Got a pull request up your sleeve?

@narfbg
Owner

I guess it should just be switched from:

header('Cache-Control: must-revalidate, post-check=0, pre-check=0');

to:

header('Cache-Control: no-cache');

no?

@narfbg narfbg closed this issue from a commit
Commit has since been removed from the repository and is no longer available.
@narfbg narfbg closed this in 0bb79f6
@narfbg narfbg referenced this issue from a commit
@narfbg narfbg Fix #1146 d87f6bf
@nonchip nonchip referenced this issue from a commit in nonchip/CodeIgniter
@narfbg narfbg Fix #1146 28c7010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.