Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Nintendo DS User Agent in mobile #1695

Closed
StevenWeathers opened this Issue Aug 10, 2012 · 2 comments

Comments

Projects
None yet
3 participants

I recently grabbed the latest user_agents config to update for android and others, and had some issues with IE8.
Apparently the User Agent string includes MDDS for some machines, not sure what that really is but the underlying issue I had was that 'ds' => 'Nintendo DS' was causing my clients site to show the mobile version for some IE8 users. I've commented this out as we really don't care about Nintendo DS users (i don't think they've even had 1). Perhaps you guys should look at this, as I doubt many sites support/have nintendo ds visitors but do have plenty of IE8 users.

-Thanks

Contributor

cryode commented Aug 12, 2012

Do you have the exact user agent string that contains MDDS? Might help for reference.

Based on all the info I can find regarding DS user agents, it seems that adding "nintendo" to the array key would be sufficient. Any agents that didn't include "nintendo" had Opera Mini defined, which will still toggle as mobile.

Just incase anyone wanted it heres the user agent string that had the issue.

Mozilla/4.0 (compatibile; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; MDDS; .NET4.0C; .NET4.0E)

@narfbg narfbg closed this in 19d0f56 Aug 16, 2012

narfbg added a commit that referenced this issue Aug 16, 2012

Merge pull request #1698 from cryode/develop
Bug fix #1695 Update Nintendo mobile user agents.

nonchip pushed a commit to nonchip/CodeIgniter that referenced this issue Jun 29, 2013

Bug fix #1695 - change Nintendo mobile user agents to be more specific.
Signed-off-by: Eric Roberts <eric@cryode.com>

nonchip pushed a commit to nonchip/CodeIgniter that referenced this issue Jun 29, 2013

Remove change log entry for Bug fix #1695
Signed-off-by: Eric Roberts <eric@cryode.com>

nonchip pushed a commit to nonchip/CodeIgniter that referenced this issue Jun 29, 2013

Merge pull request #1698 from cryode/develop
Bug fix #1695 Update Nintendo mobile user agents.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment