Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

minify output javascript problem #2092

Closed
hakimihamdan88 opened this Issue · 6 comments

4 participants

@hakimihamdan88

i have problem with my google analytics (javascript error) when updating new update develop version

@AndrewPodner

Can you provide some more details about where the problem is, and what JS code is involved.

@vkeranov

varjs is not defined... Using the twitter api:

!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");

well, thanks for this hard work and commits, but if you're not testing javascript with twitter api or google analytics, then how you're testing it at all?

@AndrewPodner

As mentioned by @narfbg in #2078 , "Minify output isn't perfect - it's experimental." If you want to provide a PR to improve it, or even the js code prior to minification, or a link to it, that would be most helpful. Thanks!

@vkeranov

This js code is "as is", taken from the twitter developer's site... Almost every website, which has a "tweet this" button, uses this code. If you're using Google Analytics the code is provided in the same way... Sorry, but I can not give you another code. This is the link:
https://dev.twitter.com/docs/tweet-button

@AndrewPodner

Exactly what I needed, thanks. Fix will be forthcoming.

@AndrewPodner AndrewPodner referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@AndrewPodner AndrewPodner referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@AndrewPodner AndrewPodner referenced this issue from a commit in AndrewPodner/CodeIgniter
@AndrewPodner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 79b7027
@AndrewPodner AndrewPodner referenced this issue from a commit in AndrewPodner/CodeIgniter
@AndrewPodner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 464a7b7
@AndrewPodner AndrewPodner referenced this issue from a commit in AndrewPodner/CodeIgniter
@AndrewPodner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 58594ed
@AndrewPodner AndrewPodner referenced this issue from a commit in AndrewPodner/CodeIgniter
@AndrewPodner AndrewPodner issue #2092 : code refinements 96b9501
@AndrewPodner

@vkeranov @hakimihamdan88 I believe we have the reported issues solved. Please post back if you continue to have an issue. Thanks for reporting the issue

@narfbg narfbg closed this
@nonchip nonchip referenced this issue from a commit in nonchip/CodeIgniter
@AndrewPodner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 2a1c6ba
@nonchip nonchip referenced this issue from a commit in nonchip/CodeIgniter
@AndrewPodner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method 56ba5ac
@nonchip nonchip referenced this issue from a commit in nonchip/CodeIgniter
@AndrewPodner AndrewPodner issue #2092 : Improve/Revise JS and CSS minify method c0b7041
@nonchip nonchip referenced this issue from a commit in nonchip/CodeIgniter
@AndrewPodner AndrewPodner issue #2092 : code refinements 679bcdd
@narfbg narfbg referenced this issue from a commit
@narfbg narfbg Remove output minifier
This feature has proven to be problematic and it's not nearly
as flexible as a dedicated minifier library like Minify
(http://www.minifier.org/, https://github.com/matthiasmullie/minify).

The same results in terms of saving traffic can also be achievied via
gzip compression (which should also be done on the httpd level, but we
also support anyway) and stuff like mod_pagespeed.

Reverts PR #965

Related issues as a track record proving how problematic this has been:

#2078 #1499 #2163 #2092 #2387 #2637 #2710 #2120 #2171 #2631 #2326 #2795
#2791 #2772

Additionally, the count of contributors suggesting that the only way
to fix the minifier problems is to remove it, is around the same as
the count of people suggesting the feature to be implemented in the
first place. It was experimental anyway ... the experiment failed.
466e8cc
@ghost Unknown referenced this issue from a commit in goreilly/CodeIgniter
@narfbg narfbg Remove output minifier
This feature has proven to be problematic and it's not nearly
as flexible as a dedicated minifier library like Minify
(http://www.minifier.org/, https://github.com/matthiasmullie/minify).

The same results in terms of saving traffic can also be achievied via
gzip compression (which should also be done on the httpd level, but we
also support anyway) and stuff like mod_pagespeed.

Reverts PR #965

Related issues as a track record proving how problematic this has been:

#2078 #1499 #2163 #2092 #2387 #2637 #2710 #2120 #2171 #2631 #2326 #2795
#2791 #2772

Additionally, the count of contributors suggesting that the only way
to fix the minifier problems is to remove it, is around the same as
the count of people suggesting the feature to be implemented in the
first place. It was experimental anyway ... the experiment failed.
03dadb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.