form_open misbehaves with empty attributes

[igbanam]

Creating a form does not use the post method if an empty array object is passed into the attributes argument.

I looked up the code [line 47 of form_helper.php] and it expects an empty string—I am on the develop branch

Can this be changed to accommodate empty arrays? Or is this how the CodeIgniter team wants it?

Thanks

[narfbg]

Line 47 of system/helpers/form_helper.php is \t * and is a part of a docblock, I don't know what you're looking at, but it's not an up-to-date code.

[vlakoff]

Though, I confirm igravity's issue, form_open() needs some fixes ;-)

[igbanam]

Thanks (:

And I will also update my codebase.

Sent from an Asteroid in Space

-----Original Message-----
From: vlakoff notifications@github.com
Date: Fri, 26 Jul 2013 04:57:36
To: EllisLab/CodeIgniterCodeIgniter@noreply.github.com
Reply-To: EllisLab/CodeIgniter reply@reply.github.com
Cc: iGbanam iGravityxigbanam@gmail.com
Subject: Re: [CodeIgniter] form_open misbehaves with empty attributes (#2560)

Though, I confirm igravity's issue, form_open() needs some fixes ;-)

---

Reply to this email directly or view it on GitHub:
#2560 (comment)

[igbanam]

disregard f75c78f, it has a typo

⏩ c122511

I also found this may help out with the multipart form_open

[vlakoff]

In addition to this issue, I found other things that can be improved, I just need a bit of spare time to make it...

[vlakoff]

Some issues with current code:

• error if is_array($attributes) && isset($attributes['method']) because the following stripos($attributes, 'method=') is executed
• code repetition between form_open() and _attributes_to_string()