Fix CSS in default template and error templates #295

Closed
kuboslav opened this Issue Aug 25, 2011 · 1 comment

Projects

None yet

3 participants

@kuboslav

First error is wrong wendor prefix in pseudo-element selection:

::selection{ background-color: #E13300; color: white; }
::-moz-selection{ background-color: #E13300; color: white; }
::-webkit-selection{ background-color: #E13300; color: white; }

Then add to #container -moz prefix and non-prefix version of box-shadow

#container {
    box-shadow: 0 0 8px #D0D0D0;
    -moz-box-shadow: 0 0 8px #D0D0D0;
    -webkit-box-shadow: 0 0 8px #D0D0D0;
}
@danijelb danijelb added a commit to danijelb/CodeIgniter that referenced this issue Aug 25, 2011
@danijelb danijelb fix for issue #295 ab9baa2
@danijelb danijelb added a commit to danijelb/CodeIgniter that referenced this issue Aug 26, 2011
@danijelb danijelb added #295 to changelog 9cad149
@svivian
svivian commented Feb 10, 2012

Just noticed this issue in CI myself. BTW, it's generally preferred to list the non-prefix version of a property last, so it would go -moz-box-shadow, -webkit-box-shadow, then box-shadow. Also for the selection classes, you should avoid duplication:

::-moz-selection, ::-webkit-selection, ::selection { background-color: #E13300; color: white; }
@narfbg narfbg closed this in 0af0258 Oct 5, 2012
@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this issue Jun 29, 2013
@narfbg narfbg Manually apply pull #300 (fixes #295) [ci skip] dc57fb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment