function _explode_segments #388

Closed
silv3rm00n opened this Issue Sep 5, 2011 · 1 comment

2 participants

@silv3rm00n

Instead of this :

$this->segments[] = $val;

how about this :

$this->segments[] = urldecode($val);

In a certain case where the segments contained [ or ] characters the uri parsing was incorrect.

Regards
Silver

@narfbg

Can you give an example of when/how it fails?

@narfbg narfbg added a commit that referenced this issue Oct 31, 2012
@narfbg narfbg Fix issues #388 & #705
(thanks to @sourcejedi, PR #1326 for pointing inconsistencies with RFC2616
9dd2dbb
@narfbg narfbg closed this Oct 31, 2012
@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this issue Jun 29, 2013
@narfbg narfbg Fix issues #388 & #705
(thanks to @sourcejedi, PR #1326 for pointing inconsistencies with RFC2616
eb43188
@narfbg narfbg added a commit that referenced this issue Feb 18, 2015
@narfbg narfbg Fix #3593
Revert "fixes" for #167, #388, #705 (also #1326) as it turns out
URL-decoding isn't compliant with the CGI/1.1 specification.

RFC 3875: http://www.faqs.org/rfcs/rfc3875.html
0ae4e6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment