Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

only the default_controller is to lowered #98

Closed
bitbucket-import opened this Issue · 2 comments

4 participants

@bitbucket-import

on line 96 in Router.php the default_controller is changed to lowered.... but controllers parsed from the uri are not. i suggest one of the following...
1) taking out the strtolower on the default controller.
2) move the strtolower to the set_class function.

@cristobal

Have to agree on this.
Why not just take out the strtolower from the default controller since there is no such restriction for other controllers.
Or either conform to making all controller files to lowercase and specify it in the documentation.

Additionally some servers and php configuration are not case sensitive when checking if the file_exists. Which is the error i ran into on my own configuration when moving my code developed locally to the live server, where my ie. MyController.php was not parsed for the default_controller option in the config/routes.php. But on the server the file was not found for the default_controller option, but ran well for the other routes specified for the MyController.php class for a given action MyController/action since the resulting controller filename lookup was not lowered.

@narfbg narfbg closed this issue from a commit
@narfbg narfbg Fix #98 a3f5c5c
@narfbg narfbg closed this in a3f5c5c
@dmyers2004

Any chance this can be rolled into a update on Master?
I had to search for over an hour to local this issue on my production server when I deployed (wasn't live yet but certainly throw a monkey wrench in the plan)
I'm not exactly interested in running "dev" on my production servers.

@nonchip nonchip referenced this issue from a commit in nonchip/CodeIgniter
@narfbg narfbg Fix #98 1d97465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.