Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added multiple database management to the Database Forge Class #1358

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

Repox commented May 15, 2012

This pull request addresses issue #84

Contributor

narfbg commented May 15, 2012

Strange ... I remember doing something like this. I've probably stashed the patch somewhere.
Anyway, you don't need to add a constructor in each driver - just add it to CI_DB_forge and CI_DB_utility.

Contributor

Repox commented May 15, 2012

You are absoluty right - the unnecessary costructors are removed.
Though, I havent thought of doing this to the Utility class. Looking into the Loader, I see that the Database Forge class is loaded when asking for the Utility class. This will require additional changes which I will look into.

Contributor

toopay commented May 15, 2012

I had similar try in the past : #650. Using inversion of control technique(s) like this one, to pull those DB dependencies, is one thing i want to see not only in DB stuff, but also in Security, Input and other core classes, in the future major release. I would like to know how @derekjones @philsturgeon @pkriete think about this.

Contributor

Repox commented May 15, 2012

@toopay Adding the ability to use multiple connections to the database forge and utility classes are definitely needed.
At the moment, I'm using some really ugly hacks to accomplish this which is why I'm giving my suggestion to an implementation. That and a fix to a small bug in the DB_Utillity class :)

Contributor

narfbg commented Nov 5, 2012

@narfbg narfbg closed this Nov 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment