Changed default tags to (from ) in the highlight_phrase() method in text helper #1497

alexbilbie · 2012-06-17T09:27:47Z

I've changed the default tag for the highlight_phrase() method in the text helper from  to .

The  tag semantically represents highlighted text in HTML5. The spec details can be found here http://www.w3.org/TR/html5/the-mark-element.html#the-mark-element

narfbg · 2012-06-17T14:44:16Z

Not sure it's appropriate to set it as default at this point, considering it's HTML 5.

alexbilbie · 2012-06-18T09:37:37Z

I don't think because it is HTML5 it should stop it being used. It's semantically valid and the appropriate tag for this use case. Also browsers that don't understand the tag natively will still render the text inside it.

What do you think @philsturgeon @derekjones @pkriete @ericbarnes ?

narfbg · 2012-06-18T09:49:51Z

If it doesn't exist in the HTML specifications prior to HTML 5, then it wouldn't be semantically valid for them. And while the text will be rendered - it won't be highlighted.

alexbilbie · 2012-06-18T09:59:54Z

But then if we're going to wait for the HTML5 specification to be complete (and the section with the  tag has been finalised) this pull request is going to be open until 2020.

narfbg · 2012-06-18T10:10:21Z

It is an optional parameter, so everybody can change it to use the  tag if they're developing an HTML5 application. It's just that changing the default might break it for existing apps that are not HTML5-ready.

Another thought however - I'm completely out of touch with the feature/html5 branch, but if there's some configuration setting or auto-detection on wether we use HTML 5 - it could be changed to depend on that in there.

alexbilbie · 2012-06-18T11:25:52Z

True that users can currently set whichever tag they want in the function - but it's currently a  which is now, with the advent of the  tag, is the incorrect tag to use.

As for the auto-detection I strongly believe that is the wrong approach to go down

narfbg · 2012-06-18T11:48:19Z

I'm not arguing on what is right or wrong, I'm just saying we have to maintain backwards-compatibility. :)

vkeranov · 2012-06-18T14:28:11Z

make it HTML5 :)
Most of the browsers already support it. We don't need to think about IE6 still, don't we? Besides, everybody can do:

mark { font-weight: bolder; }

ericlbarnes · 2012-06-18T14:37:47Z

My opinion is we should start converting all helpers that generate html to html5.

tkaw220 · 2012-06-18T14:46:49Z

There're still users who simply can't or don't know how to move away from IE6. Backwards-compatibility won't hurt in this case IMHO.

narfbg · 2012-06-18T15:22:17Z

I'm not talking about IE6 users, even Microsoft badly wants the IE6 problem to go away. This one isn't (directly) related to browsers' market share - it's about the already existing CodeIgniter applications. Correct me if I'm wrong, but to my knowledge no standard prior to HTML 5 has the  tag, which means that it would break validation for those standards, while  (I assume) is valid for HTML 5 as well.

I'm not against pushing for a wider HTML 5 adoption - I'm all for it, but it should happen in a less painful way.

derekjones · 2012-06-18T15:25:56Z

EllisLab no longer supports IE6 at all, FYI. That's not a determining factor here, but I thought I'd mention it in case there was worry that we might demand that it work with dead browsers.

One solution would be to move CI's helpers to HTML 5, and maintain a separate repo of helpers for HTML 4 versions for those that need them.

…lder browsers

alexbilbie · 2012-06-18T15:35:30Z

In 3d8d4fb I've added a note on how to add styling for browsers which may not have default styling for 

hArpanet · 2012-07-01T21:25:12Z

I'm apathetic to this pull request. The point of a 'default' value is that it is the most commonly used value. With the relative newness of HTML 5 I can't see that moving from to can be the most commonly used value.

I'm not against this request either as I can see it makes sense, however, this pull request has stimulated a discussion about HTML 5 not about whether the default needs changing, and I believe it would be better to have a proper discussion elsewhere and an agreed date as to when CI implements all 'common' elements of HTML 5, rather than it being a debate on each pull request of this type. Decide when HTML 5 becomes the CI standard and then implement all these pulls.

It wouldn't hurt either if the docs specifically highlighted when and where HTML 5 features had been used. (Note: I had to use tags here as tags are not implemented!)

…ight_phrase Conflicts: user_guide_src/source/changelog.rst

alexbilbie · 2012-07-31T12:09:40Z

I've updated this pull so it will auto merge and it now includes an upgrade note.

So what's the decision on introducing HTML5 into CI?

philsturgeon · 2012-07-31T12:10:49Z

HTML5 is king?

Phil Sturgeon

On Tuesday, 31 July 2012 at 13:09, Alex Bilbie wrote:

I've updated this pull so it will auto merge and it now includes an upgrade note.

So what's the decision on introducing HTML5 into CI?

Reply to this email directly or view it on GitHub:
#1497 (comment)

alexbilbie · 2012-07-31T12:52:50Z

In the IRC people have suggested we have a $config['html5'] flag.

Personally I'm against this however if others think this is a better option then can I suggest we have it set to TRUE by default

philsturgeon · 2012-07-31T13:05:26Z

I believe we talked before about having "doctype" or some other co fig switch that could be set to "xhtml" or "html5" or whatever, but as long as its optional I'm not too fussed.

Emailing from my iPhone 4S like a BOSS!

On 31 Jul 2012, at 13:52, Alex Bilbiereply@reply.github.com wrote:

In the IRC people have suggested we have a $config['html5'] flag.

Personally I'm against this however if others think this is a better option then can I suggest we have it set to TRUE by default

Reply to this email directly or view it on GitHub:
#1497 (comment)

alexbilbie · 2012-07-31T13:28:01Z

<?php
function highlight_phrase($str, $phrase, $tag_open = '', $tag_close = '')
{
    if ($tag_open === '' && $tag_close === '')
    {
        $tag_open = (config_item('HTML5')) ? '<mark>' : '<strong>';
        $tag_close = (config_item('HTML5')) ? '</mark>' : '</strong>';
    }

    if ($str === '')
    {
        return '';
    }

    if ($phrase !== '')
    {
        return preg_replace('/('.preg_quote($phrase, '/').')/i', $tag_open.'\\1'.$tag_close, $str);
    }

    return $str;
}

ckdarby · 2013-01-03T14:38:01Z

@alexbilbie Where does this stand?

marcvdm · 2013-06-01T23:04:36Z

I think that the config option is great way to start introducing html5. Just make an option where you can choose between html5 and normal and make it default to normal.

That way future html5 change requests can make use of this config.

You will still be backwards compatible and yet give people the choice for html5

ivantcholakov · 2013-07-30T17:40:50Z

The current default values '' and '' do not have much sense. The author of the original text most probably would "occupy" these tags and when the system highlights a phrase surrounded with "strong" tag, it would not be visible. A wise developer would already need to add a specific class, for example ''.

This is why a change of these default values would not be such a pain. Anyway, within the instruction for upgrade, those who want to use the "strong" tag might be advised to declare highlight_phrase() with the old defaults within MY_text_helper.php

Autodetection for HTML5 is a messy approach IMO.

Anyway, we are going to swallow the new class and file naming convention, so this change is not so big concern about backward compatibility. The tag really makes sense.

ivantcholakov · 2013-07-30T18:08:38Z

+1 for the initially proposed change.

This example works for me (Opera 12.16, IE 10, Firefox 22.0, Crome 28, Safari 5.1.7).

Supersedes PR #1497

Changed highlight_phrase default tags to (from )

14cea6e

Added changelog note for changes to highlight_phrase()

f492da8

alexbilbie added 2 commits June 18, 2012 16:31

Updated the example response for highlight_phrase()

c2b7889

Added a note about how to add default styling for the tag in o…

3d8d4fb

…lder browsers

alexbilbie added 3 commits July 31, 2012 12:59

Merge remote-tracking branch 'ellislab/develop' into alexbilbie-highl…

4376fa4

…ight_phrase Conflicts: user_guide_src/source/changelog.rst

Added an upgrade note

9a52207

Fixed merge conflict in changelog.rst

2aea296

marcvdm mentioned this pull request Jun 1, 2013

Captcha color parameter missing #867

Closed

narfbg added a commit that referenced this pull request Jan 7, 2014

Change Text helper default tag from to 

ac023e1

Supersedes PR #1497

narfbg closed this Jan 7, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed default tags to <mark> (from <strong>) in the highlight_phrase() method in text helper #1497

Changed default tags to <mark> (from <strong>) in the highlight_phrase() method in text helper #1497

alexbilbie commented Jun 17, 2012

narfbg commented Jun 17, 2012

alexbilbie commented Jun 18, 2012

narfbg commented Jun 18, 2012

alexbilbie commented Jun 18, 2012

narfbg commented Jun 18, 2012

alexbilbie commented Jun 18, 2012

narfbg commented Jun 18, 2012

vkeranov commented Jun 18, 2012

ericlbarnes commented Jun 18, 2012

tkaw220 commented Jun 18, 2012

narfbg commented Jun 18, 2012

derekjones commented Jun 18, 2012

alexbilbie commented Jun 18, 2012

hArpanet commented Jul 1, 2012

alexbilbie commented Jul 31, 2012

philsturgeon commented Jul 31, 2012

alexbilbie commented Jul 31, 2012

philsturgeon commented Jul 31, 2012

alexbilbie commented Jul 31, 2012

ckdarby commented Jan 3, 2013

marcvdm commented Jun 1, 2013

ivantcholakov commented Jul 30, 2013

ivantcholakov commented Jul 30, 2013

Changed default tags to <mark> (from <strong>) in the highlight_phrase() method in text helper #1497

Changed default tags to <mark> (from <strong>) in the highlight_phrase() method in text helper #1497

Conversation

alexbilbie commented Jun 17, 2012

narfbg commented Jun 17, 2012

alexbilbie commented Jun 18, 2012

narfbg commented Jun 18, 2012

alexbilbie commented Jun 18, 2012

narfbg commented Jun 18, 2012

alexbilbie commented Jun 18, 2012

narfbg commented Jun 18, 2012

vkeranov commented Jun 18, 2012

ericlbarnes commented Jun 18, 2012

tkaw220 commented Jun 18, 2012

narfbg commented Jun 18, 2012

derekjones commented Jun 18, 2012

alexbilbie commented Jun 18, 2012

hArpanet commented Jul 1, 2012

alexbilbie commented Jul 31, 2012

philsturgeon commented Jul 31, 2012

alexbilbie commented Jul 31, 2012

philsturgeon commented Jul 31, 2012

alexbilbie commented Jul 31, 2012

ckdarby commented Jan 3, 2013

marcvdm commented Jun 1, 2013

ivantcholakov commented Jul 30, 2013

ivantcholakov commented Jul 30, 2013