Move database utility load to separate method in CI_Migration class #1509

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

Dumk0 commented Jun 19, 2012

It is wise to move dbforge loader out of __construct(), else the CI_Migration class is hard to extend.
With this change developers can use other db utility, skip automatic table creation, etc.

Contributor

philsturgeon commented Jun 24, 2012

Based on the use-case it might be more logical to rename this to something else.

_check_schema() or whatever.

Contributor

Dumk0 commented Jun 25, 2012

I would also name with a general word like _init() or something, up to you guys. I just need to overwrite it in my extension. :)

Contributor

narfbg commented Oct 24, 2012

You're still calling that new method from within the constructor, so what does that improve?

Contributor

narfbg commented Jan 29, 2013

Outdated, no feedback for 3 months and no obvious benefit from it - closing.

narfbg closed this Jan 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment