Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix / Disallowed Key Characters. #1730

Merged
merged 1 commit into from Nov 5, 2012

Conversation

Projects
None yet
3 participants
Contributor

Damao commented Aug 20, 2012

China's biggest ICP China Telecom will hijack user and leave a cookie contains | .

such as "1345466626|7601294|43373|0|0|0"
it's impossible to fix this shit for my Chinese user...

@Damao Damao China's biggest ICP China Telecom will hijack user and leave a cookie…
… contains | .

such as "1345466626|7601294|43373|0|0|0"
it's impossible to fix this shit...
3c0846b
Contributor

alexbilbie commented Sep 2, 2012

Is this really the case? I couldn't find any reference to this happening in a quick Google search

Contributor

narfbg commented Nov 1, 2012

I don't object the proposed change, as long as it doesn't introduce a security risk. AFAIK - it won't, but I don't know why the pipe wasn't allowed in the first place.

Contributor

alexbilbie commented Nov 5, 2012

I can't come up with any reasons why this should break anything or introduce a security flaw so I'll merge it.

@alexbilbie alexbilbie added a commit that referenced this pull request Nov 5, 2012

@alexbilbie alexbilbie Merge pull request #1730 from damao/develop
Fix / Disallowed Key Characters.
8e8937b

@alexbilbie alexbilbie merged commit 8e8937b into bcit-ci:develop Nov 5, 2012

@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013

@alexbilbie alexbilbie Merge pull request #1730 from damao/develop
Fix / Disallowed Key Characters.
69fa99d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment