print_debugger() now accepts three optional parameters to decide what the function returns #1759

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@jleft
jleft commented Sep 2, 2012

The function now accepts three boolean parameters for: header, subject and body (including attachment data). The user can decide what combination of the above the function should return. The parameters all have a default value of TRUE, so it is fully backwards compatible with the previous version of the function. The debug message(s) will be returned regardless of what the parameters are set to.

@jleft jleft print_debugger() now accepts three optional parameters to decide what…
… the function returns (Issue #1742)

The function now accepts three boolean parameters for: header, subject
and body (including attachment data). The user can decide what
combination of the above the function should return. The parameters all
have a default value of TRUE, so it is fully backwards compatible with
the previous version of the function.
2f98139
@ckdarby
ckdarby commented Oct 11, 2012

I agree with the old way that all debugging information should be sent.

Putting my personal preferences aside I will not back code like this because it allows for future parameter creep.

Please change this to option array to be passed instead of the tri-parameter set up.

@narfbg narfbg added a commit that referenced this pull request Nov 26, 2012
@narfbg narfbg CI_Email::print_debugger() option to limit the type of data to be pri…
…nted

(an alternative to PR #1759; partially solves issue #1742)
61797f6
@narfbg
Collaborator
narfbg commented Nov 26, 2012

See the above commit.

@narfbg narfbg closed this Nov 26, 2012
@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013
@narfbg narfbg CI_Email::print_debugger() option to limit the type of data to be pri…
…nted

(an alternative to PR #1759; partially solves issue #1742)
53e84be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment