add new mime type (binary/octet-stream) to pdf that is generated by Micr... #1828

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

add new mime type (binary/octet-stream) to pdf that is generated by Microsoft Word 2010

Contributor

alexbilbie commented Sep 29, 2012

Please pull the latest changes from ellislab/codeigniter/develop so that I can merge this

marcelod commented Oct 1, 2012

OK, but what I did know. Anything could help me? thank you

Contributor

ckdarby commented Oct 1, 2012

@marcelod I don't fully understand your comment but I think you're having some issues knowing what Alex is asking of you.

This article here explains some of the details of what he's asking you specifically steps 4 & 4.5

Contributor

alexbilbie commented Oct 1, 2012

Thanks @ckdarby, @marcelod my apologies if you didn't understand what I said

ckdarby referenced this pull request Oct 1, 2012

Closed

Fast Forward Pull #1828 #1839

Contributor

ckdarby commented Oct 1, 2012

@alexbilbie The above will be his changes up to date.

Contributor

ckdarby commented Oct 1, 2012

@alexbilbie Nevermind @marcelod sorted out his fast forward I believe here... #1840

marcelod commented Oct 1, 2012

People, sorry, but I don't understand english (I use very google translate) and my understanding with github is very little, but I try and I want to learn. Tks

@alexbilbie alexbilbie added a commit that referenced this pull request Oct 2, 2012

@alexbilbie alexbilbie Added 'binary/octet-stream' as PDF mime. Fixes #1840 and #1828
Signed-off-by: Alex Bilbie <alex@alexbilbie.com>
50f7834

alexbilbie closed this Oct 2, 2012

@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013

@alexbilbie alexbilbie Added 'binary/octet-stream' as PDF mime. Fixes #1840 and #1828
Signed-off-by: Alex Bilbie <alex@alexbilbie.com>
8848721

saada commented Nov 8, 2013

Release CI 3 already! 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment