Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bug-fix in XML-RPC library #1854

Merged
merged 1 commit into from

2 participants

Dimitar Mihaylov Andrey Andreev
Dimitar Mihaylov

$type and $typeof are passed as strings in this function, therefore I took the easy way and simplified the validation.

I tested with different requests (strings, numbers ..), no other issues found.

Dimitar Mihaylov tocaibiza Bug-fix in XML-RPC library
$type and $typeof are passed as strings in this function, therefore I took the easy way and simplified the validation.

I tested with different requests (strings, numbers ..), no other issues found.
740480a
Andrey Andreev narfbg merged commit 4a1b418 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 5, 2012
  1. Dimitar Mihaylov

    Bug-fix in XML-RPC library

    tocaibiza authored
    $type and $typeof are passed as strings in this function, therefore I took the easy way and simplified the validation.
    
    I tested with different requests (strings, numbers ..), no other issues found.
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 4 deletions.
  1. +4 −4 system/libraries/Xmlrpc.php
8 system/libraries/Xmlrpc.php 100644 → 100755
View
@@ -1317,15 +1317,15 @@ public function __construct($val = -1, $type = '')
{
$type = $type === '' ? 'string' : $type;
- if ($this->xmlrpcTypes[$type] === 1)
+ if ($this->xmlrpcTypes[$type] == 1)
{
$this->addScalar($val,$type);
}
- elseif ($this->xmlrpcTypes[$type] === 2)
+ elseif ($this->xmlrpcTypes[$type] == 2)
{
$this->addArray($val);
}
- elseif ($this->xmlrpcTypes[$type] === 3)
+ elseif ($this->xmlrpcTypes[$type] == 3)
{
$this->addStruct($val);
}
@@ -1351,7 +1351,7 @@ public function addScalar($val, $type = 'string')
return 0;
}
- if ($typeof !== 1)
+ if ($typeof != 1)
{
echo '<strong>XML_RPC_Values</strong>: not a scalar type (${typeof})<br />';
return 0;
Something went wrong with that request. Please try again.