Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix #1938 #1945

Merged
merged 6 commits into from Oct 30, 2012

Conversation

Projects
None yet
2 participants
Contributor

GDmac commented Oct 30, 2012

Where the email library removed multiple spaces inside a plain text message.

Signed-off-by: GDmac grdalenoort@gmail.com

Fix #1938
Where the email library removed multiple spaces inside a plain text message.

Signed-off-by: GDmac <grdalenoort@gmail.com>
Contributor

GDmac commented Oct 30, 2012

I moved the "remove spaces" part to the get_alt_message method.
A generated alt message, from an html email, will still get extra spaces removed.

Contributor

narfbg commented Oct 30, 2012

Could you add a changelog entry for that?

Contributor

GDmac commented Oct 30, 2012

How does this work when there are inbetween commits? rebase, merge?

Contributor

narfbg commented Oct 30, 2012

Merge works, but pull is better:

git pull git@github.com:EllisLab/CodeIgniter.git develop

(you're out of sync currently)

Description for Fix #1938 added to changelog (sync)
Conflicts:
	user_guide_src/source/changelog.rst

Signed-off-by: GDmac <grdalenoort@gmail.com>

narfbg added a commit that referenced this pull request Oct 30, 2012

@narfbg narfbg merged commit 936a8fe into bcit-ci:develop Oct 30, 2012

nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment