Fixed typo in logs #1964

Merged
merged 1 commit into from Nov 3, 2012

Conversation

Projects
None yet
2 participants
Contributor

Razican commented Nov 3, 2012

There was a typo in the logs library. It would give a PHP error.

EDIT:
It would create a log file that had a PHP error in it.

Contributor

narfbg commented Nov 3, 2012

It's not a typo and it won't cause an error.
If that was the case, none of the files included with CI would produce an error: c5536aa

narfbg closed this Nov 3, 2012

Contributor

Razican commented Nov 3, 2012

@narfbg please, read it through. There is a PHP error in the logs. When it creates a new log file it inserts this at the start of the file:

And if you try to run the log file, you get this:
Parse error: syntax error, unexpected 'defined' (T_STRING), expecting '(' in **** on line 1

The thing is that it must be a confusion. It should be one of these two:

OR

Contributor

narfbg commented Nov 3, 2012

Right ... sorry about that.

narfbg reopened this Nov 3, 2012

@narfbg narfbg added a commit that referenced this pull request Nov 3, 2012

@narfbg narfbg Merge pull request #1964 from Razican/log_fix
Fixed typo in logs
d7677ab

@narfbg narfbg merged commit d7677ab into bcit-ci:develop Nov 3, 2012

1 check passed

default The Travis build passed
Details
Contributor

Razican commented Nov 3, 2012

No problem ;)

@nonchip nonchip pushed a commit to nonchip/CodeIgniter that referenced this pull request Jun 29, 2013

@narfbg narfbg Merge pull request #1964 from Razican/log_fix
Fixed typo in logs
029e614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment